Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: can you update dependency for vite 3? #16

Closed
waynebrantley opened this issue Aug 8, 2022 · 7 comments
Closed

Bug: can you update dependency for vite 3? #16

waynebrantley opened this issue Aug 8, 2022 · 7 comments
Assignees
Labels
dependencies Pull requests that update a dependency file

Comments

@waynebrantley
Copy link

No description provided.

@Shinigami92 Shinigami92 self-assigned this Aug 8, 2022
@Shinigami92 Shinigami92 added the dependencies Pull requests that update a dependency file label Aug 8, 2022
@Shinigami92
Copy link
Owner

@waynebrantley please test out v1.1.0 and report any issues (I haven't tested myself ^^')
If something broke, please re-open this issue and say what's wrong
Otherwise have a nice day :)

@waynebrantley
Copy link
Author

@Shinigami92 would you consider adding vite 4 now?

@Shinigami92
Copy link
Owner

There is a breaking change in the warning

this.warn(error);

Therefore I do not have time this evening to investigate

@waynebrantley
Copy link
Author

@Shinigami92 ok no problem - FYI - I am using the current version with V4 successfully

[vite:dts] Start generate declaration files...
┌─────────┬──────────┐
│ (index) │   time   │
├─────────┼──────────┤
│  build  │ '0.5[24] │
│ render  │ '0.093s' │
│  full   │ '0.798s' │
└─────────┴──────────┘
[vite:dts] Declaration files built in 3685ms.

@Shinigami92
Copy link
Owner

@Shinigami92 ok no problem - FYI - I am using the current version with V4 successfully

[vite:dts] Start generate declaration files...
┌─────────┬──────────┐
│ (index) │   time   │
├─────────┼──────────┤
│  build  │ '0.5[24] │
│ render  │ '0.093s' │
│  full   │ '0.798s' │
└─────────┴──────────┘
[vite:dts] Declaration files built in 3685ms.

That's good to know, but it might fail if in any kind of way an error would be thrown, logging the error as warning now might be broken due to underlying API changes
Or the Error might be converted to a string and might result in e.g. [object Object]

@Shinigami92
Copy link
Owner

@waynebrantley to keep you up to date: I reported an issue at rollup/rollup#4754
Feel free to subscribe to that one
I will wait on an answer there, and want to omit to introduce an unneeded breaking change, so that I can still support Vite 2-4 with the same code base

@Shinigami92
Copy link
Owner

@waynebrantley I released 2.1.0
Please report and open new issues when new problems occur

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

2 participants