Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage of pickle may be unsafe #374

Open
mbalunovic opened this issue Apr 19, 2024 · 1 comment
Open

Usage of pickle may be unsafe #374

mbalunovic opened this issue Apr 19, 2024 · 1 comment

Comments

@mbalunovic
Copy link

Note that pickle is not secure (see https://docs.python.org/3/library/pickle.html) and can lead to remote code execution:

slack_token = pickle.load(token_file)

Loading the tokens from an alternative file format such as JSON would be safer, given the intended use-case of an agent that can write to the file system. In theory someone using goex with their agent could be prompt injected and the agent could try to overwrite the token.pickle file with an arbitrary python code (unless properly sandboxed).

@ShishirPatil
Copy link
Owner

Thanks for raising this @mbalunovic! If you want to go ahead and raise a PR we'd be happy to welcome you as a contributor :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants