RAFT raft.py CLI arguments naming broke --embedding-model and --completion-model in PR #410

[cedricvidal]

Is the feature request related to a problem?
PR #410 introduced a breaking change in the CLI arguments names:

• --embedding-model was renamed to --embedding_model
• --completion-model was renamed to --completion_model

It also breaks the documentation which stills uses the dash-case naming convention.

It seems like this was done to align to the double dash prefixed snake-case naming convention used with the other --chunk_size argument.

Here are the changed lines:
624d371#diff-b81150e1021ea386316094b5858fd74e2cbc1b1f1acc1dc37ed63d1507c87727L38-R44

Describe the solution you'd like
Having a consistent naming convention is important but the double dash prefixed snake case convention is quite unusual for CLI arguments. They usually use the dash-case naming convention.

While this is not a big deal, I would vote to change all arguments to dash-case like so:

• --embedding-model
• --completion-model
• --chunk-size

This would also align with the dash-case convention used in eval.py.

[kaiwen129]

Hi Cedric, I'd certainly be open to using dash-case for all arguments. I did originally use snake case to align with the chunk_size argument but I think what you said makes more sense.