Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ActiveRecord, Postgres/MySQL #180

Open
Aubermean opened this issue Mar 6, 2024 · 3 comments
Open

Support ActiveRecord, Postgres/MySQL #180

Aubermean opened this issue Mar 6, 2024 · 3 comments

Comments

@Aubermean
Copy link

Would it be possible to use postgres as the store, rather than mysql + trilogy? Or is there some major reasoning why mysql was chosen? Thanks!

@devanandersen
Copy link
Contributor

@Aubermean 👋🏼

There shouldn't be any blockers for adding Postgres support, ensuring that we don't use any non-standard SQL statements in any implementations.

If we use ActiveRecord as an abstraction, and no MySQL-specific database statements are used we should be alright.

@Aubermean
Copy link
Author

Hi, thank you for confirming! I know this is a Shopify-first engine that you are most likely abstracting from a greater monolith, and I know you guys use Trilogy... but I think supporting plain old ActiveRecord and mysql/postgres would be helpful for the greater community :)

@devanandersen
Copy link
Contributor

Hi, thank you for confirming! I know this is a Shopify-first engine that you are most likely abstracting from a greater monolith, and I know you guys use Trilogy... but I think supporting plain old ActiveRecord and mysql/postgres would be helpful for the greater community :)

There's no reason for us not to do so in Atlas Engine, I agree! We welcome contributions and are available for review. Worst case we'll have this issue in our back pocket when we can allocate some time to support 🙂

@devanandersen devanandersen changed the title Trilogy, pg Support ActiveRecord, Postgres/MySQL Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants