Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to fail the whole process if spinner fails #491

Open
fatkodima opened this issue Feb 13, 2024 · 0 comments
Open

Ability to fail the whole process if spinner fails #491

fatkodima opened this issue Feb 13, 2024 · 0 comments

Comments

@fatkodima
Copy link

Currently, when the error is raised inside a Frame, the whole process is halt, see

cli-ui/lib/cli/ui/frame.rb

Lines 127 to 131 in b9e35ed

rescue
closed = true
t_diff = elapsed(t_start, timing)
close(failure_text, color: :red, elapsed: t_diff, to: to)
raise

I would like to have a similar ability for spinners - to be able to pass some config option when creating a spinner, so that if it fails it halts the whole process. Currently, the spinner is only marked as failed and the process continues.

Are you open for such a feature? I can help with a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant