You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
In which of these areas are you experiencing a problem?
Hydrogen custom storefront
Expected behavior
Errors in internal telemetry should not be shown as unhandled rejections. The error should be caught and printed nicely, and maybe only as a debug log.
Actual behavior
For example, when running without internet connection, the following log shows up in the console when running a CLI command (e.g. shopify hydrogen dev):
I'm not able to reproduce. I tried by disabling the internet connection, but I can't see any telemetry error. For example, with hydrogen dev, I only get this one:
╭─ warning ───────────────────────────────────────────────────────────────────────────────────────────────────────────────╮
│ │
│ Failed to fetch Hydrogen changelog │
│ │
│ Ensure you have internet connection and try again │
│ │
╰─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯
Looking at the code, it seems that we are already catching errors and printing only to debug log:
Please confirm that you have:
In which of these areas are you experiencing a problem?
Hydrogen custom storefront
Expected behavior
Errors in internal telemetry should not be shown as unhandled rejections. The error should be caught and printed nicely, and maybe only as a debug log.
Actual behavior
For example, when running without internet connection, the following log shows up in the console when running a CLI command (e.g.
shopify hydrogen dev
):Verbose output
Reproduction steps
Operating System
Mac OS Sonoma 14
Shopify CLI version (check your project's
package.json
if you're not sure)3.59.2
Shell
zsh
Node version (run
node -v
if you're not sure)v18.7.1
What language and version are you using in your application?
No response
The text was updated successfully, but these errors were encountered: