Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does it make sense to replace AbstractEvent with CustomEvent? #536

Open
hnrq opened this issue Aug 14, 2022 · 2 comments
Open

Does it make sense to replace AbstractEvent with CustomEvent? #536

hnrq opened this issue Aug 14, 2022 · 2 comments

Comments

@hnrq
Copy link
Contributor

hnrq commented Aug 14, 2022

I'm playing around with this lib and I wanted to make a version of my own using modern techs (Vite, testing-library and others). I've seen it has an AbstractEvent class where all Events extend from. Could this class be replaced by the CustomEvent class?

@hnrq hnrq changed the title DISCUSSION: Does it make sense to replace AbstractEvent with CustomEvent? Does it make sense to replace AbstractEvent with CustomEvent? Aug 14, 2022
@zjffun
Copy link
Contributor

zjffun commented Aug 24, 2022

I think it can be replaced by CustomEvent. We need to check compatibility and use CustomEvent here.

@hnrq
Copy link
Contributor Author

hnrq commented Aug 25, 2022

Looking into CustomEvent at caniuse, looks like it has support for all major browsers except IE, but, like it was mentioned before here, maybe it's time to move on from IE11. I'll submit a PR in a near future for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants