From 9d9590de3e619f8673743a40f8829c19c88eab84 Mon Sep 17 00:00:00 2001 From: Ben Scott Date: Fri, 18 Oct 2019 14:00:10 -0700 Subject: [PATCH] PR Feedback --- scripts/new-version-pr-generator.js | 1 + scripts/utilities/retry.js | 1 + 2 files changed, 2 insertions(+) diff --git a/scripts/new-version-pr-generator.js b/scripts/new-version-pr-generator.js index 884cc059ba4..9200a170bca 100644 --- a/scripts/new-version-pr-generator.js +++ b/scripts/new-version-pr-generator.js @@ -114,6 +114,7 @@ mkdir(sandbox); const jobs = repositories.map((repository) => { // We should fix this but I've not got the time at the moment + // SEE https://eslint.org/docs/rules/no-async-promise-executor // eslint-disable-next-line no-async-promise-executor return new Promise(async (resolve, reject) => { try { diff --git a/scripts/utilities/retry.js b/scripts/utilities/retry.js index bb72aeb75ae..da231ec7817 100644 --- a/scripts/utilities/retry.js +++ b/scripts/utilities/retry.js @@ -4,6 +4,7 @@ function sleep(ms) { function retry(functionToTry, maxAttempts = 3, delay = 1000) { // We should fix this but I've not got the time at the moment + // SEE https://eslint.org/docs/rules/no-async-promise-executor // eslint-disable-next-line no-async-promise-executor return new Promise(async (resolve, reject) => { let remainingAttempts = maxAttempts;