You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi there,
As I see the bundle of polaris-tokens is large, after investigated, I see there are a lot of data are unnecessary and actually unused anywhere.
The whole ideas of the polaris-tokens should be the variables & tokenization only, it should not contains any content or rendering copy data. If the dev team can wipe out those data, we can save a bit of package size.
For example in the polaris-tokens/src/themes/base/, many files contain the description just to be used in the docs (I guess). color.ts file here is an example.
And the root index file that includes the whole base/ files, will be built as module and will contain those copy inside the bundle.
I think the dev team should bring the content to other directory or data files, and exclude them from polaris-tokens built bundle.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Hi there,
As I see the bundle of polaris-tokens is large, after investigated, I see there are a lot of data are unnecessary and actually unused anywhere.
The whole ideas of the polaris-tokens should be the variables & tokenization only, it should not contains any content or rendering copy data. If the dev team can wipe out those data, we can save a bit of package size.
For example in the
polaris-tokens/src/themes/base/
, many files contain the description just to be used in the docs (I guess).color.ts
file here is an example.And the root index file that includes the whole
base/
files, will be built as module and will contain those copy inside the bundle.I think the dev team should bring the content to other directory or data files, and exclude them from
polaris-tokens
built bundle.Beta Was this translation helpful? Give feedback.
All reactions