Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete with loading status is not working #3048

Closed
dhmacs opened this issue Jun 12, 2020 · 12 comments · Fixed by #4015
Closed

Autocomplete with loading status is not working #3048

dhmacs opened this issue Jun 12, 2020 · 12 comments · Fixed by #4015
Assignees
Labels
Bug Something is broken and not working as intended in the system.

Comments

@dhmacs
Copy link

dhmacs commented Jun 12, 2020

Issue summary

When typing into an autocomplete field to filter out options, the options dialog collapses to a thin line.

Expected behavior

When typing into the autocomplete field the dialog should show the filtered options

Actual behavior

The options dialog collapses into a thin line

Steps to reproduce the problem

  1. Go to the docs for autocomplete component https://polaris.shopify.com/components/forms/autocomplete#navigation
  2. Select "Autocomplete with loading" example
  3. Type into the textfield a string that matches one of the options (e.g. Rustic)
@raphpap
Copy link

raphpap commented Jul 14, 2020

To add to this: in the Autocomplete with loading example, if you type two characters quickly, the options dialog will show up.

i.e. Type re and the Refurbished option will show up. If you type r then e, it won't.

The bug also occurs without using the loading prop. Here's an example

@linxianxi
Copy link

So did I. Did anyone fix it???

@linxianxi
Copy link

@BPScott

@BPScott
Copy link
Member

BPScott commented Aug 7, 2020

If this error still occurs on polaris.shopify.com then it sounds like it remains unfixed.
I've not got much context on Autocomplete, though I believe @dleroux was looking at improvements to it a while back.

Alternatively if you're able to identify and fix the problem we'd welcome a PR as most of the team's focus is elsewhere currently.

@dleroux
Copy link
Contributor

dleroux commented Aug 7, 2020

I’m planning on improving the autocomplete but no timeline has been set for this work yet. In the meantime a PR to fix this issue would be more than welcomed.

@alainemackenzie
Copy link

@dfmcphee anything we can do to get this prioritized on the Polaris team? It seems, uh.. not great.. to have this visibly broken on our public style guide, product page tags, HS code search, etc.

@Flufd did some initial investigation, but our devs are all hustling for our Code Red deadline Oct 30th so I don't think we're able to prioritize it on cross-border team. Anyone that can help out here?

@larouxn
Copy link

larouxn commented Sep 23, 2020

👋 Hey all, just want to mention that this issue (as far as I know) affects Shopify Payments Japan's onboarding bank info section as well as it uses the same autocomplete dropdown component. Will be following this issue. 🙇‍♂️

@aya-kamikawa, @winston, @yishus, @codeAbul

@jonpulsifer jonpulsifer added the Bug Something is broken and not working as intended in the system. label Dec 23, 2020
@linxianxi
Copy link

I have tested it. It is the height calculation problem of the popover component. But I don't know how to fix it. The popover code is too complicated.Officials have plans to fix it???

@dleroux
Copy link
Contributor

dleroux commented Jan 6, 2021

👋 @linxianxi I'm not sure the popover height is related to this issue. I am no longer part of the team actively working on this but I did work on something that is being looked at as a possible solution to this.

@linxianxi
Copy link

Not using Loading also causes this problem.I'm sure the popover height is related to this issue.Because I forked this library and then replace the popover in the component with the popover from another component library(antd) doesn't have this problem.

@jlyon
Copy link

jlyon commented Feb 19, 2021

We're excited to start using Polaris 6 now that it is released, but we dynamic Autocompletes in multiple places in our apps so this issue is a deal-breaker for us. We also tried diving into this code to try to fix it, but weren't able to find the right place to tie into the popover code. Is this something that is still actively being looked at? If not, could you give some pointers on where in the code to look for a solution? Thanks!

@jlyon
Copy link

jlyon commented Mar 2, 2021

We have confirmed that #4015 fixed this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken and not working as intended in the system.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants