Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor JWT to use around_action when needed instead of middleware used with every request #1744

Open
nelsonwittwer opened this issue Nov 7, 2023 · 1 comment
Assignees

Comments

@nelsonwittwer
Copy link
Contributor

Overview/summary

We currently use a JWT middleware to parse the JWT for every request that is made to a rails app that uses this gem. For actions that don't need to make API calls to Shopify we are still spending time logging and trying to parse a token that doesn't exist. For applications that have a large amount of traffic, this inefficiency adds up.

We should explore moving that logic to our controller concerns as part of a around_action or before_action filter so we only parse JWT when we know it'll be there.

@tgwizard tgwizard self-assigned this Nov 10, 2023
@tgwizard tgwizard removed their assignment Jan 9, 2024
@danielpgross danielpgross self-assigned this May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@tgwizard @nelsonwittwer @danielpgross and others