New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eslint rule to avoid updating a ref in the render method #229

Open

michenly opened this issue Apr 8, 2021 · 0 comments

Labels

Package: eslint-plugin

Contributor

michenly commented Apr 8, 2021 •

edited

Motivation

The pattern come from these two issues:
Shopify/quilt#1813
facebook/react#18545

TL;DR
React core team is in discussion on adding warming for this and we can stop the bleeding earlier by adding this as a lint rule.

🚫 fail lint:
mutate refs in render method.

✅ pass lint:
mutate ref in a useEffect

michenly added the Package: eslint-plugin label

marutypes mentioned this issue

[react-form | DynamicList] add reset function and dirty state Shopify/quilt#1828

Merged

2 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment