From d320b557723870bfa20860c6205abf84e5e10a4e Mon Sep 17 00:00:00 2001 From: Pulkit Singhal Date: Fri, 15 Sep 2017 13:12:12 -0700 Subject: [PATCH] Update dependencies `request` and `request-promise` ... all tests passed ## Motivation - Some upstream projects that use `vend-nodejs-sdk` were facing strange issues where long-running use (after 47 minutes or so) led so a situation where nodejs would just hang after a POST request. - There weren't any clear CPU or Memory consumption red flags. - It seemed more like a bad promise chain or failing to invoke a callback that often leads nodejs into a forever running state and there's nothing really going on. ## Solution Look at the [CHANGELOG](https://github.com/request/request/blob/master/CHANGELOG.md) for `request` and see if any plausible reasons for trying a module update. 1. https://github.com/request/request/pull/2431 2. https://github.com/request/request/pull/2414 3. https://github.com/request/request/pull/2447 4. https://github.com/request/request/pull/2448 This wasn't an exact science but their descriptions seemed to merit the dependency upgrade as "at least worth a try" ## Consequences Dropped support for Node 0.10 https://github.com/request/request/pull/2381 --- package.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/package.json b/package.json index 38a0543..788177e 100644 --- a/package.json +++ b/package.json @@ -56,7 +56,8 @@ "bluebird": "2.6.0", "moment": "2.9.0", "nconf": "0.7.1", - "request-promise": "0.3.2", + "request": "2.81.0", + "request-promise": "4.2.1", "underscore": "1.7.0", "winston": "0.9.0" },