Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How come the code in the commands directory is example only? #11

Open
caseycrites opened this issue Jan 24, 2017 · 1 comment
Open

How come the code in the commands directory is example only? #11

caseycrites opened this issue Jan 24, 2017 · 1 comment

Comments

@caseycrites
Copy link
Contributor

At first glance, these seem fully functional, and except for the hardcoding of the test credentials, ready to go for production use. Is there a reason the user is encouraged to write their own versions?

@kevinburke
Copy link
Contributor

I think they'd be fine, but yeah you'd want to add some sort of way to load credentials that's not hardcoding them. You might also want to configure the number of workers differently.

It might be instructive to look at the custom Shyp code that wraps these. I believe I added a custom Authenticator that either let you specify a password, or use a valid username/token that you'd use to authenticate to Control.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants