Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voronoi plots are not compatible with numpy>=1.24.0 #34

Open
lschall opened this issue Aug 30, 2023 · 8 comments
Open

Voronoi plots are not compatible with numpy>=1.24.0 #34

lschall opened this issue Aug 30, 2023 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@lschall
Copy link
Member

lschall commented Aug 30, 2023

With updating to numpy 1.24.0 (see release information) numpy finally expired the deprecation for ragged/inhomogeneous (see here). For the voronoi plots we are generating in the efficiency plotting e.g. here we are using matplotlib.patches which needs a ragged array of the form [[x, y], height, width] as input see here for matplotlib.patches documentation. This will cause the script to fail for latest numpy versions.
So far I have not found a way to fix this other than limiting numpy<1.24.0. Maybe matplotlib will adapt to this (not so new) numpy version soon?

@lschall lschall added the bug Something isn't working label Aug 30, 2023
@YannickDieter
Copy link
Collaborator

Any update @lschall ?

@lschall lschall self-assigned this Nov 13, 2023
@lschall
Copy link
Member Author

lschall commented Nov 13, 2023

Will look into it this week again, sorry.

@leloup314
Copy link
Member

This is fixed in unit_tests branch by fixing the respective versions

@YannickDieter
Copy link
Collaborator

Thanks! did not know that you pushed to this branch I used before

@lschall
Copy link
Member Author

lschall commented Nov 13, 2023

I am aware of this. I was planning to adapt the plot to be able to run on numpy>1.23

@leloup314
Copy link
Member

I made a PR before ;)

@leloup314
Copy link
Member

Which was open for 2 weeks and merged yesterday

@YannickDieter
Copy link
Collaborator

Okay, sorry now I got it! Let me know when you are ready to merge to master :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants