Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error type should ignore URLs #9

Open
3 tasks done
notheotherben opened this issue Oct 21, 2019 · 0 comments
Open
3 tasks done

Error type should ignore URLs #9

notheotherben opened this issue Oct 21, 2019 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@notheotherben
Copy link
Member

Problem Statement

When processing an error which includes a URL like https://google.com this library will mark the scheme (and any preceding text) as the error type.

Expected Behaviour

Errors like not found: we could not find the item you were looking for should have their type extracted correctly (not found) while errors containing URLs should ignore the URL for the purpose of extracting the error type.

Environment

Tell us about the environment you are using

  • Go Version: go version go1.13.2 windows/amd64 (go version)
  • Sentry Version: latest
  • Updated sentry-go.v2 (go get -u gopkg.in/SierraSoftworks/sentry-go.v2)

Reproduction Code

package main

import (
  "fmt"
  "os"

  "gopkg.in/SierraSoftworks/sentry-go.v1"
)

func main() {
  cl := sentry.NewClient(
    sentry.Release(fmt.Sprintf("#%s", os.Getenv("ISSUE_ID"))),
  )
  
  cl.Capture(
    sentry.ExceptionForError(fmt.Errorf("GET https://google.com: 404 not found")),
  )
}
@notheotherben notheotherben added the bug Something isn't working label Oct 21, 2019
@notheotherben notheotherben self-assigned this Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant