Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Node version check before server upgrade #1134

Open
tkurki opened this issue Sep 21, 2020 · 0 comments · May be fixed by #1135
Open

Implement Node version check before server upgrade #1134

tkurki opened this issue Sep 21, 2020 · 0 comments · May be fixed by #1135

Comments

@tkurki
Copy link
Member

tkurki commented Sep 21, 2020

We can query npm for abbreviated package metadata with

curl -H "Accept: application/vnd.npm.install-v1+json" https://registry.npmjs.org/signalk-server

and get back metadata containing the engines section of package.json

image

so we can implement easily a check that compares the server's node version to what the next installed version would require.

Related to #1133 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@tkurki