Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Pre-Built Binary #54

Open
louisefindlay23 opened this issue May 10, 2021 · 8 comments
Open

Windows Pre-Built Binary #54

louisefindlay23 opened this issue May 10, 2021 · 8 comments

Comments

@louisefindlay23
Copy link
Collaborator

The Readme instructs to see the Releases section for pre-built binaries but there only seems to be one for Mac. Since Electron apps are cross-platform, are there plans to build a release for Windows and Linux?

@SimHub
Copy link
Owner

SimHub commented May 11, 2021

Hi louisefindlay23,
there no plans to build a release for Window and Linux, It's just a side Project of mine. But if you wich to release it on various platforms, maybe this could help:

"We use electron-builder to handle the packaging process. It has a lot of customization options, which you can declare under "build" key in package.json. You can package your app cross-platform from a single operating system, electron-builder kind of supports this, but there are limitations and asterisks. That's why this boilerplate doesn't do that by default."

Since this Project uses electron-builder you might want to take a look at it.
I am sure you'll figure it out and make this app awesome.

Happy coding 🥳

@louisefindlay23
Copy link
Collaborator Author

Thanks, @SimHub. Managed to build a Windows exe that I've installed and it seems to work perfectly.

Also, interested in meeting link support and possibly styling events like Fantastical does by Meeting Platform (for virtual events).

Is there any particular format you'd prefer to receive contributions or just fork and PR?

@SimHub
Copy link
Owner

SimHub commented May 12, 2021

Hi @louisefindlay23 , there is currently no preferred code formatting other than using Prettier.
But it would be nice to comment on important steps. Unfortunately, I failed to do that - I'm still learning
I really appreciate that you want to make contributions. Thank's 🙂

@louisefindlay23
Copy link
Collaborator Author

Have linked to the binary since you can't merge releases across forks. Happy to PR it in a releases folder though if you prefer.

Does the content for the calendar div get rendered through app.js?

@SimHub
Copy link
Owner

SimHub commented May 19, 2021

Hi @louisefindlay23, sorry for the late reply.

Yes! the content for the calendar get rendered through app.js.
The application consists of two main folders...

  1. src - files within this folder get transpiled or compiled (because Electron can't use them directly). In other words, here is where the magic happens🎉
  2. app - contains all static assets which don't need any pre-processing. Put here images, CSSes, HTMLs, etc.

I'm sending you an invitation so you can upload your releases right away. If you want to commit, please commit in a feature branch "louisefindlay23-feature-" or something like that.

Have fun and happy coding 🥳

@louisefindlay23
Copy link
Collaborator Author

Thanks, @SimHub. Will branch off (and use suggested branch naming structure) if I'm commiting any code. Can you resend the collaborator invite? I'm afraid it expired.

@SimHub
Copy link
Owner

SimHub commented May 31, 2021

👋🏽 @louisefindlay23,
just opened a project board. Not sure if you can edit it right now. If so, feel free to use it.
It's a good way to review progress and keeping track of new features

@louisefindlay23
Copy link
Collaborator Author

Thanks, @SimHub. Yes, I can edit the project board and have added some of the features I'm looking to implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants