Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: SimonCropp/Polyfill
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 5.6.0
Choose a base ref
...
head repository: SimonCropp/Polyfill
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 6.0.0
Choose a head ref
  • 12 commits
  • 5 files changed
  • 1 contributor

Commits on Jul 10, 2024

  1. refs and cleanup

    SimonCropp committed Jul 10, 2024
    Copy the full SHA
    b595ffd View commit details
  2. refs and cleanup

    SimonCropp committed Jul 10, 2024
    Copy the full SHA
    e0a1cd1 View commit details
  3. Merge branch 'main' of https://github.com/SimonCropp/Polyfill

    SimonCropp committed Jul 10, 2024
    Copy the full SHA
    d48f9c5 View commit details
  4. refs and cleanup

    SimonCropp committed Jul 10, 2024
    Copy the full SHA
    c2c7353 View commit details

Commits on Jul 14, 2024

  1. refs or cleanup

    SimonCropp committed Jul 14, 2024
    Copy the full SHA
    ead701f View commit details

Commits on Jul 15, 2024

  1. refs and cleanup

    SimonCropp committed Jul 15, 2024
    Copy the full SHA
    51fcc42 View commit details

Commits on Jul 18, 2024

  1. Update .editorconfig

    SimonCropp committed Jul 18, 2024
    Copy the full SHA
    a6bfffd View commit details
  2. move from WithMetadataValue to AnyHaveMetadataValue (#194)

    SimonCropp authored Jul 18, 2024
    Copy the full SHA
    5e0436a View commit details
  3. Update Polyfill.targets

    SimonCropp committed Jul 18, 2024
    Copy the full SHA
    4838c6e View commit details
  4. require at least version 4.5.5 of System.Memory (#195)

    SimonCropp authored Jul 18, 2024
    Copy the full SHA
    81fdf1f View commit details
  5. Update Directory.Build.props

    SimonCropp committed Jul 18, 2024
    Copy the full SHA
    ac82217 View commit details
  6. Update Directory.Build.props

    SimonCropp committed Jul 18, 2024
    Copy the full SHA
    9ba1813 View commit details
Showing with 20 additions and 17 deletions.
  1. +8 −8 src/.editorconfig
  2. +1 −1 src/Directory.Build.props
  3. +1 −1 src/Directory.Packages.props
  4. +9 −6 src/Polyfill/Polyfill.targets
  5. +1 −1 src/global.json
16 changes: 8 additions & 8 deletions src/.editorconfig
Original file line number Diff line number Diff line change
@@ -153,7 +153,7 @@ trim_trailing_whitespace = true
csharp_preferred_modifier_order = public, private, protected, internal, new, static, abstract, virtual, sealed, readonly, override, extern, unsafe, volatile, async:suggestion
resharper_namespace_body = file_scoped
dotnet_naming_rule.private_constants_rule.severity = warning
dotnet_naming_rule.private_constants_rule.style = upper_camel_case_style
dotnet_naming_rule.private_constants_rule.style = lower_camel_case_style
dotnet_naming_rule.private_constants_rule.symbols = private_constants_symbols
dotnet_naming_rule.private_instance_fields_rule.severity = warning
dotnet_naming_rule.private_instance_fields_rule.style = lower_camel_case_style
@@ -162,7 +162,7 @@ dotnet_naming_rule.private_static_fields_rule.severity = warning
dotnet_naming_rule.private_static_fields_rule.style = lower_camel_case_style
dotnet_naming_rule.private_static_fields_rule.symbols = private_static_fields_symbols
dotnet_naming_rule.private_static_readonly_rule.severity = warning
dotnet_naming_rule.private_static_readonly_rule.style = upper_camel_case_style
dotnet_naming_rule.private_static_readonly_rule.style = lower_camel_case_style
dotnet_naming_rule.private_static_readonly_rule.symbols = private_static_readonly_symbols
dotnet_naming_style.lower_camel_case_style.capitalization = camel_case
dotnet_naming_style.upper_camel_case_style.capitalization = pascal_case
@@ -189,7 +189,7 @@ resharper_arrange_object_creation_when_type_evident_highlighting = error
resharper_arrange_object_creation_when_type_not_evident_highlighting = error
resharper_arrange_redundant_parentheses_highlighting = error
resharper_arrange_static_member_qualifier_highlighting = error
resharper_arrange_this_qualifier_highlighting = hint
resharper_arrange_this_qualifier_highlighting = error
resharper_arrange_type_member_modifiers_highlighting = none
resharper_built_in_type_reference_style_for_member_access_highlighting = hint
resharper_built_in_type_reference_style_highlighting = hint
@@ -232,11 +232,11 @@ dotnet_style_predefined_type_for_locals_parameters_members = true:error
dotnet_style_predefined_type_for_member_access = true:error

# Suggest more modern language features when available
dotnet_style_object_initializer = true:suggestion
dotnet_style_collection_initializer = true:suggestion
dotnet_style_coalesce_expression = false:suggestion
dotnet_style_null_propagation = true:suggestion
dotnet_style_explicit_tuple_names = true:suggestion
dotnet_style_object_initializer = true:error
dotnet_style_collection_initializer = true:error
dotnet_style_coalesce_expression = false:error
dotnet_style_null_propagation = true:error
dotnet_style_explicit_tuple_names = true:error

# Prefer "var" everywhere
csharp_style_var_for_built_in_types = true:error
2 changes: 1 addition & 1 deletion src/Directory.Build.props
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="utf-8"?>
<Project>
<PropertyGroup>
<Version>5.6.0</Version>
<Version>6.0.0</Version>
<AssemblyVersion>1.0.0</AssemblyVersion>
<PackageTags>Polyfill</PackageTags>
<DisableImplicitNamespaceImports>true</DisableImplicitNamespaceImports>
2 changes: 1 addition & 1 deletion src/Directory.Packages.props
Original file line number Diff line number Diff line change
@@ -9,7 +9,7 @@
<PackageVersion Include="Mono.Cecil" Version="0.11.5" />
<PackageVersion Include="NUnit" Version="3.14.0" />
<PackageVersion Include="NUnit3TestAdapter" Version="4.5.0" />
<PackageVersion Include="ProjectDefaults" Version="1.0.128" />
<PackageVersion Include="ProjectDefaults" Version="1.0.131" />
<PackageVersion Include="SimpleInfoName" Version="2.2.0" />
<PackageVersion Include="System.Memory" Version="4.5.5" />
<PackageVersion Include="System.Net.Http" Version="4.3.4" />
15 changes: 9 additions & 6 deletions src/Polyfill/Polyfill.targets
Original file line number Diff line number Diff line change
@@ -12,7 +12,7 @@
</PropertyGroup>
<PropertyGroup Condition="$(PolyNullability) == 'true' ">
<DefineConstants>$(DefineConstants);PolyNullability</DefineConstants>
</PropertyGroup>
</PropertyGroup>
<PropertyGroup Condition="$(LowerFramework.StartsWith('netcoreapp2'))">
<DefineConstants>$(DefineConstants);NETCOREAPP2X</DefineConstants>
</PropertyGroup>
@@ -76,16 +76,19 @@ For example:
<Target Name="PreparePolyfill" DependsOnTargets="ResolvePackageAssets">
<PropertyGroup>
<DefineConstants
Condition="@(ResolvedCompileFileDefinitions->WithMetadataValue('NuGetPackageId', 'System.ValueTuple')->Count()) != 0">$(DefineConstants);FeatureValueTuple</DefineConstants>
Condition="@(ResolvedCompileFileDefinitions->AnyHaveMetadataValue('NuGetPackageId', 'System.ValueTuple'))">$(DefineConstants);FeatureValueTuple</DefineConstants>

<MemoryVersion>@(ResolvedCompileFileDefinitions->WithMetadataValue('NuGetPackageId', 'System.Memory')->Metadata('NuGetPackageVersion'))</MemoryVersion>

<DefineConstants
Condition="@(ResolvedCompileFileDefinitions->WithMetadataValue('NuGetPackageId', 'System.Memory')->Count()) != 0">$(DefineConstants);FeatureMemory</DefineConstants>
Condition="'$(MemoryVersion)' != '' AND $([MSBuild]::VersionGreaterThanOrEquals($(MemoryVersion), '4.5.5'))">$(DefineConstants);FeatureMemory</DefineConstants>

<DefineConstants
Condition="@(ResolvedCompileFileDefinitions->WithMetadataValue('NuGetPackageId', 'System.Threading.Tasks.Extensions')->Count()) != 0">$(DefineConstants);FeatureValueTask</DefineConstants>
Condition="@(ResolvedCompileFileDefinitions->AnyHaveMetadataValue('NuGetPackageId', 'System.Threading.Tasks.Extensions'))">$(DefineConstants);FeatureValueTask</DefineConstants>

<DefineConstants
Condition="@(ResolvedCompileFileDefinitions->WithMetadataValue('NuGetPackageId', 'System.Net.Http')->Count()) != 0 OR @(Reference->WithMetadataValue('Identity', 'System.Net.Http')->Count()) != 0">$(DefineConstants);FetureHttp</DefineConstants>
Condition="@(ResolvedCompileFileDefinitions->AnyHaveMetadataValue('NuGetPackageId', 'System.Net.Http')) OR @(Reference->AnyHaveMetadataValue('Identity', 'System.Net.Http'))">$(DefineConstants);FetureHttp</DefineConstants>

<DefineConstants Condition="$(LowerFramework.StartsWith('net9'))">$(DefineConstants);FeatureMemory;FeatureValueTuple;FeatureValueTask</DefineConstants>
<DefineConstants Condition="$(LowerFramework.StartsWith('net8'))">$(DefineConstants);FeatureMemory;FeatureValueTuple;FeatureValueTask</DefineConstants>
<DefineConstants Condition="$(LowerFramework.StartsWith('net7'))">$(DefineConstants);FeatureMemory;FeatureValueTuple;FeatureValueTask</DefineConstants>
2 changes: 1 addition & 1 deletion src/global.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"sdk": {
"version": "9.0.100-preview.5.24307.3",
"version": "9.0.100-preview.6.24328.19",
"allowPrerelease": true,
"rollForward": "latestFeature"
}