Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Will MySqlEntityFrameworkCoreSpanMetadataProvider support MySqlConnector? #536

Open
1 of 4 tasks
MyNine opened this issue Feb 7, 2023 · 0 comments
Open
1 of 4 tasks

Comments

@MyNine
Copy link

MyNine commented Feb 7, 2023

Please answer these questions before submitting your issue.

  • Why do you submit this issue?
  • Question or discussion
  • Bug
  • Requirement
  • Feature or performance improvement

Question

  • What do you want to know?

The virtual database requires that the span must be exit.
Currently, for "SkyApm.Diagnostics.EntityFrameworkCore.Pomelo.MySql", only when the value of connection.GetType().FullName is "MySql.Data.MySqlClient.MySqlConnection" the span wii be set to exit.

public bool Match(DbConnection connection)
{
return connection.GetType().FullName == "MySql.Data.MySqlClient.MySqlConnection";
}

However, the Pomelo.EntityFrameworkCore.MySql has useed MySqlConnector for high-performance database server communication.


Bug

  • Which version of SkyWalking, OS and .NET Runtime?

  • Which company or project?

  • What happen?
    If possible, provide a way for reproducing the error. e.g. demo application, component version.


Requirement or improvement

  • Please describe about your requirements or improvement suggestions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant