Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A large number of httpclients and tcp are created when the oap server is unavailable #541

Open
1 of 4 tasks
saber-wang opened this issue Feb 22, 2023 · 3 comments
Open
1 of 4 tasks
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@saber-wang
Copy link

saber-wang commented Feb 22, 2023

Please answer these questions before submitting your issue.

  • Why do you submit this issue?
  • Question or discussion
  • Bug
  • Requirement
  • Feature or performance improvement

Bug

Here's the problem:

if (_channel != null)
{
await ShutdownAsync();
}

It is executed every 15 seconds. At this time, it is offline and the GrpcChannel is recreated. Each time the GrpcChannel is created, a new httpclient instance will be created.

Optional fixes:

Provide your own httpclient for GrpcChannel and reuse httpclient instances.

In addition, ShutdownAsync does not seem to be implemented?
image

@liuhaoyang liuhaoyang added bug Something isn't working enhancement New feature or request labels Feb 22, 2023
@liuhaoyang liuhaoyang self-assigned this Feb 22, 2023
@saber-wang
Copy link
Author

@liuhaoyang There is a repair plan?

@saber-wang
Copy link
Author

@liuhaoyang
I tried to process and found that the httpclient created when based on netstandard 2.0 is not available. If I reuse it directly_ Channel doesn't seem to be rebuilding Tongtong.

我尝试处理发现在基于netstandard2.0时创建的httpclient不可用,如果直接复用_channel 似乎不会重建通通。

@liuhaoyang
Copy link
Collaborator

@liuhaoyang I tried to process and found that the httpclient created when based on netstandard 2.0 is not available. If I reuse it directly_ Channel doesn't seem to be rebuilding Tongtong.

我尝试处理发现在基于netstandard2.0时创建的httpclient不可用,如果直接复用_channel 似乎不会重建通通。

It may be better to release the old connection completely when retrying the gRPC connection

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants