New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should 'IExitSegmentContextAccessor' be used here? #552

Open

2 of 4 tasks

saber-wang opened this issue Mar 31, 2023 · 0 comments

Open

2 of 4 tasks

Should 'IExitSegmentContextAccessor' be used here? #552

saber-wang opened this issue Mar 31, 2023 · 0 comments

saber-wang commented Mar 31, 2023 •

edited

Please answer these questions before submitting your issue.

Why do you submit this issue?
Question or discussion
Bug
Requirement
Feature or performance improvement

Question

SkyAPM-dotnet/src/SkyApm.Core/Tracing/SegmentContextAccessor.cs

Line 40 in 606a14d

_entrySegmentContextAccessor.Context ?? _entrySegmentContextAccessor.Context;

Should it be like this?

 _localSegmentContextAccessor.Context ??
            _entrySegmentContextAccessor.Context ?? _exitSegmentContextAccessor.Context;

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment