Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

this is no service name display in Virtual Database #566

Open
3 tasks
ivanmissu opened this issue Sep 18, 2023 · 3 comments
Open
3 tasks

this is no service name display in Virtual Database #566

ivanmissu opened this issue Sep 18, 2023 · 3 comments

Comments

@ivanmissu
Copy link

Please answer these questions before submitting your issue.

  • Why do you submit this issue?
  • [✅ ] Question or discussion
  • Bug
  • Requirement
  • Feature or performance improvement

Question

  • What do you want to know?
    this is no service name display in Virtual Database

Bug

  • Which version of SkyWalking, OS and .NET Runtime?
    SkyWalking version : 9.4.0
    OS: LINUX CentOS 7.9
    .NET RUNTIME: 3.1

  • Which company or project?

  • What happen?
    If possible, provide a way for reproducing the error. e.g. demo application, component version.

image

Requirement or improvement

  • Please describe about your requirements or improvement suggestions.
@wu-sheng
Copy link
Member

You could check docs linked from the top. There are required tags to build virtual services.

@gaoshaopeng
Copy link

plz fix the bug in file src/SkyApm.Diagnostics.EntityFrameworkCore.Pomelo.MySql/MySqlEntityFrameworkCoreSpanMetadataProvider.cs as follow,

 public bool Match(DbConnection connection)
        {
            var fullName = connection.GetType().FullName;
            return fullName == "MySql.Data.MySqlClient.MySqlConnection" || fullName == "MySqlConnector.MySqlConnection";
        }

so that the Virtual Database can be retrieved correctly.

@wu-sheng
Copy link
Member

If you want to propose some changes, feel free to submit a pull request.

This is not a bug. The dot net agent exists before the virtual database/cache/queue concept. So, it may not be aligned with the newer concept.

Welcome to contribute to the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants