Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamic choice of browser context #107

Open
LawyZheng opened this issue Mar 19, 2024 · 1 comment
Open

dynamic choice of browser context #107

LawyZheng opened this issue Mar 19, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed P2

Comments

@LawyZheng
Copy link
Collaborator

LawyZheng commented Mar 19, 2024

Although chromium-headless and chromium-heaful are registered into BrowserContextFactory,
we can only choose one for all tasks(workflows) because we create the type by reading the config in env.

browser_type = SettingsManager.get_settings().BROWSER_TYPE

Is it necessary to offer a dynamic option? maybe at the task(workflow) level? Like task(workflow) A could choose headless and task(workflow) B could choose headful?
Sure, the BROWSER_TYPE in the env config could be the default choice if not browser type is specified by the task(workflow).

@suchintan suchintan added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed P2 labels Mar 22, 2024
Copy link

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the Stale label Apr 27, 2024
@suchintan suchintan removed the Stale label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed P2
Projects
None yet
Development

No branches or pull requests

2 participants