Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error logs don't make sense if LLM_KEY is an empty string #130

Open
ykeremy opened this issue Mar 28, 2024 · 1 comment
Open

Error logs don't make sense if LLM_KEY is an empty string #130

ykeremy opened this issue Mar 28, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers P3

Comments

@ykeremy
Copy link
Contributor

ykeremy commented Mar 28, 2024

When the LLM_KEY is an empty string, error logs don't make sense.

Example:

class InvalidLLMConfigError(BaseLLMError):
    def __init__(self, llm_key: str) -> None:
        super().__init__(f"LLM config with key {llm_key} is not a valid LLMConfig")

Example output:
skyvern.forge.sdk.api.llm.exceptions.InvalidLLMConfigError: LLM config key with key is not a valid LLMConfig

Possible solutions:

  • Instead of LLM config key with key, it could log LLM_KEY= is not a valid LLMConfig
  • Default LLM_KEY can be FILLMEIN
  • We can handle the empty string/None cases while logging: instead of key {llm_key} is, key {llm_key if llm_key else 'EMPTY_VALUE'} is
@ykeremy ykeremy added enhancement New feature or request good first issue Good for newcomers P3 labels Mar 28, 2024
Copy link

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the Stale label Apr 28, 2024
@suchintan suchintan removed the Stale label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers P3
Projects
None yet
Development

No branches or pull requests

2 participants