Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃嚨馃嚤 Polish translations #591

Open
bogdan-the-great opened this issue Jan 6, 2024 · 10 comments
Open

馃嚨馃嚤 Polish translations #591

bogdan-the-great opened this issue Jan 6, 2024 · 10 comments
Assignees
Labels
maintenance Repetitive task

Comments

@bogdan-the-great
Copy link

This issue tracks maintenance and possible issues with Polish translation.

@bogdan-the-great
Copy link
Author

Hi @Slion, I translated 100% of the app and changed some translations. In the following days will look around and correct more stuff. Also, would you elaborate more on what assert option in debug level does (and other levels)? And could you update translations i.e. delete strings that cannot be translated?

@Slion Slion added the maintenance Repetitive task label Jan 8, 2024
@Slion
Copy link
Owner

Slion commented Jan 8, 2024

Thanks Piotr and welcome to the project. A new release is long overdue. I'll try to get it done this week and integrate your translations.

@Slion
Copy link
Owner

Slion commented Jan 8, 2024

Also, would you elaborate more on what assert option in debug level does (and other levels)?

Log levels are listed from least important to most important.
Verbose logs are the least important ones.
Assert logs are the most important ones.
An assert will typically cause your application to shutdown unexpectedly.
See logging, assert corresponds to critical. alert and emergency levels.

So if you set log level to Debug you will not see the Verbose logs, only Debug logs and below. It's only relevant if you want to help debug the app though. Hope that makes sense.

@Slion
Copy link
Owner

Slion commented Jan 8, 2024

And could you update translations i.e. delete strings that cannot be translated?

I'm always a bit reluctant to delete currently unused strings just in case we might need them again at some point. Having said that I'm sure we could do some clean up.

@bogdan-the-great
Copy link
Author

Also, would you elaborate more on what assert option in debug level does (and other levels)?

Log levels are listed from least important to most important. Verbose logs are the least important ones. Assert logs are the most important ones. An assert will typically cause your application to shutdown unexpectedly. See logging, assert corresponds to critical. alert and emergency levels.

So if you set log level to Debug you will not see the Verbose logs, only Debug logs and below. It's only relevant if you want to help debug the app though. Hope that makes sense.

Then could you add this information to Crowdin for future translators?

@bogdan-the-great
Copy link
Author

bogdan-the-great commented Jan 8, 2024

Okay I decided to not translate the log levels, because it wasn't really translatable. Someone who wants to know more about them would need to search for them online (but it'll be only a small percentage of users in Poland!).

@Slion
Copy link
Owner

Slion commented Jan 14, 2024

It's your call really. Just noticed some have been translated to French. Just published your translations in v1.9.18. Already available for download on slions.net.

@bogdan-the-great
Copy link
Author

Hi, @Slion. Do you know how do I change the Web Search string, because in Polish translation it means Search with Google and wanted to translate it better, but it doesn't even seem to show up in the string.xml.

`Web Search` in Polish

image

0 results in strings.xml

image

In Crowdin there doesn't seem to be any Web Search string.

It's all the same for explicitly changing the language to Polish, or default (with Polish system language).

@bogdan-the-great
Copy link
Author

I updated some translations and saw that there isn't a string for Discord in About:

About

image

Crowdin

image

Slion added a commit that referenced this issue Jan 18, 2024
馃嚨馃嚤 Polish

See #591
@Slion
Copy link
Owner

Slion commented Jan 18, 2024

Looks like that Discord string was hidden for some reason.
Give it a try now.
For the former question I could not find that string either so I don't really understand your problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Repetitive task
Projects
Status: In progress
Development

No branches or pull requests

2 participants