Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Active negotiation selector to the Outlet iframe/tab #183

Open
oleggrib opened this issue May 2, 2022 · 5 comments
Open

Move Active negotiation selector to the Outlet iframe/tab #183

oleggrib opened this issue May 2, 2022 · 5 comments
Assignees

Comments

@oleggrib
Copy link
Collaborator

oleggrib commented May 2, 2022

Currently user decide what token to use in the own page, where user have access to everyhting and webster can easy collect use tokens data by set mode to "passive" and track user for ads etc.
its not secure.

I suggest to move active negotiation token selector to the Outlet page.
In this case user always have to approve tokens to share, so webster cant silently track tokens where active negotiation set for Outlet.

It adds some challenge , because some browsers can force to show full size tabs, but Outlet page styles are separated from webster page and will look exact as we design it, no way to style overlap.

@nicktaras , @micwallace , @weiwu-zhang , what do you think?

@micwallace
Copy link
Collaborator

micwallace commented May 2, 2022

Agreed. I did a basic proof of concept for how this might work: http://tnwebster.tk/
Let me know if you want me to link the repo so you can play around with some ideas.

Do you reckon we need token-level approval? For instance if the Outlet hosts tickets for multiple events or vendors? This isn't possible with the current TN outlet code, but I can see how it could be useful.

@oleggrib
Copy link
Collaborator Author

oleggrib commented May 2, 2022

@micwallace , correct, this is what I mean.

also Outlet page can display switch/radio and allow user to select specific tokens to share (similar to the current token selector popup)

about option to read multiple tokens: no problem to open iframes with multiple Outlets. no need to make things more complicated. we can open Token1 Client with iframe to some.domain.com/token1.html(Token1 Outlet embedded) and Token2 Client with iframe to some.domain.com/token2.html(Token2 Outlet embedded)
In this case we have to add token name as param for all postMessages to avoid postMessages collisions between different tokens.

@nicktaras
Copy link
Collaborator

nicktaras commented May 3, 2022 via email

@oleggrib
Copy link
Collaborator Author

oleggrib commented Jul 8, 2022

@micwallace @nicktaras
is any page can request and receive all user tokens though hidden iframe?

I can see in examples that popup dont use iframe, but receive all tokens and request to select token on hotelBogota page. Right?

@nicktaras
Copy link
Collaborator

Hi @oleggrib, @micwallace,

Do we see any changes required to the management of attestations via this issue? This based on our current roadmap with regards to off chain technology.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants