Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade menu #184

Open
mitm001 opened this issue May 12, 2022 · 2 comments
Open

Upgrade menu #184

mitm001 opened this issue May 12, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@mitm001
Copy link

mitm001 commented May 12, 2022

It would be nice if the ship upgrade window defaulted to the highest level ship possible when gaining levels. Currently, if you have leveled and not selected a ship yet, it stays at the lowest level instead.

@mitm001 mitm001 added the bug Something isn't working label May 12, 2022
@finnbear
Copy link
Member

finnbear commented Jun 5, 2022

My main concern here is layout-shift e.g. you are about to upgrade to a level 5 but you collect one more point and then you end up clicking an unwanted level 6. This could theoretically be fixed by pausing automatic incrementing of the level when the mouse is near, but that isn't particularly elegant.

@caibear
Copy link
Member

caibear commented Jun 8, 2022

My main concern here is layout-shift e.g. you are about to upgrade to a level 5 but you collect one more point and then you end up clicking an unwanted level 6.

There is already a layout shift when you first get the ability to upgrade. If you are shooting weapons at the top of your screen you can accidentally click upgrade. Both of these layout shifts could be solved by adding a small delay after your upgrades change that prevents you from clicking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants