-
Notifications
You must be signed in to change notification settings - Fork 72
/
no-all-duplicated-branches.ts
87 lines (79 loc) · 3.16 KB
/
no-all-duplicated-branches.ts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
/*
* eslint-plugin-sonarjs
* Copyright (C) 2018-2021 SonarSource SA
* mailto:info AT sonarsource DOT com
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation; either
* version 3 of the License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public License
* along with this program; if not, write to the Free Software Foundation,
* Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/
// https://jira.sonarsource.com/browse/RSPEC-3923
import { TSESTree } from '@typescript-eslint/experimental-utils';
import { Rule } from '../utils/types';
import { isIfStatement } from '../utils/nodes';
import { areEquivalent } from '../utils/equivalence';
import { collectIfBranches, collectSwitchBranches } from '../utils/conditions';
import docsUrl from '../utils/docs-url';
const MESSAGE =
"Remove this conditional structure or edit its code blocks so that they're not all the same.";
const MESSAGE_CONDITIONAL_EXPRESSION =
'This conditional operation returns the same value whether the condition is "true" or "false".';
const rule: Rule.RuleModule = {
meta: {
type: 'problem',
docs: {
description:
'All branches in a conditional structure should not have exactly the same implementation',
category: 'Possible Errors',
recommended: 'error',
url: docsUrl(__filename),
},
},
create(context: Rule.RuleContext) {
return {
IfStatement(node: TSESTree.Node) {
const ifStmt = node as TSESTree.IfStatement;
// don't visit `else if` statements
if (!isIfStatement(node.parent)) {
const { branches, endsWithElse } = collectIfBranches(ifStmt);
if (endsWithElse && allDuplicated(branches)) {
context.report({ message: MESSAGE, node: ifStmt });
}
}
},
SwitchStatement(node: TSESTree.Node) {
const switchStmt = node as TSESTree.SwitchStatement;
const { branches, endsWithDefault } = collectSwitchBranches(switchStmt);
if (endsWithDefault && allDuplicated(branches)) {
context.report({ message: MESSAGE, node: switchStmt });
}
},
ConditionalExpression(node: TSESTree.Node) {
const conditional = node as TSESTree.ConditionalExpression;
const branches = [conditional.consequent, conditional.alternate];
if (allDuplicated(branches)) {
context.report({ message: MESSAGE_CONDITIONAL_EXPRESSION, node: conditional });
}
},
};
function allDuplicated(branches: Array<TSESTree.Node | TSESTree.Node[]>) {
return (
branches.length > 1 &&
branches.slice(1).every((branch, index) => {
return areEquivalent(branch, branches[index], context.getSourceCode());
})
);
}
},
};
export = rule;