Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix prefer-single-boolean-return: catch when nextNode is ReturnStatement #318

Closed
wants to merge 1 commit into from
Closed

fix prefer-single-boolean-return: catch when nextNode is ReturnStatement #318

wants to merge 1 commit into from

Conversation

dimaMachina
Copy link
Contributor

fix #316

@@ -11,5 +11,5 @@ if (strings.includes("foo")) {} // Noncompliant

for (str of strings) {} // Noncompliant

strings.forEach(str => doSomething(str)); // Noncompliant
strings.forEach(str => doSomething(str)); // Noncompliant
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@vilchik-elena
Copy link
Contributor

Hi @B2o5T
Thanks for the contribution!
I have created this PR #324 to embed your commit. Note that I changed there the way to get the next node.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prefer-single-boolean-return fails on if without else
2 participants