Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve 'prefer-single-boolean-return': report when next statement returns boolean #324

Merged
merged 4 commits into from
Feb 15, 2022
Merged

Improve 'prefer-single-boolean-return': report when next statement returns boolean #324

merged 4 commits into from
Feb 15, 2022

Conversation

vilchik-elena
Copy link
Contributor

Fixes #316

@vilchik-elena vilchik-elena mentioned this pull request Feb 15, 2022
Closed
yassin-kammoun-sonarsource
yassin-kammoun-sonarsource approved these changes Feb 15, 2022
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yassin-kammoun-sonarsource
Copy link
Contributor

@vilchik-elena You need to run ruling and update expectations to solve the build failures.

@sonarcloud
Copy link

sonarcloud bot commented Feb 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

88.2% 88.2% Coverage
0.0% 0.0% Duplication

@vilchik-elena vilchik-elena merged commit 27617cb into master Feb 15, 2022
@vilchik-elena vilchik-elena deleted the issue-316 branch February 15, 2022 10:35
@yassin-kammoun-sonarsource yassin-kammoun-sonarsource changed the title improve 'prefer-single-boolean-return': report when next statement returns boolean Improve 'prefer-single-boolean-return': report when next statement returns boolean Feb 18, 2022
@zloirock zloirock mentioned this pull request Feb 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yassin-kammoun-sonarsource yassin-kammoun-sonarsource yassin-kammoun-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

prefer-single-boolean-return fails on if without else
3 participants
@vilchik-elena @yassin-kammoun-sonarsource @dimaMachina