Improve 'no-identical-functions': add option for min function size #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/rules/no-identical-functions.ts
Outdated
Comment on lines
40
to
45
| anyOf: [ | ||
| { type: 'integer', minimum: 3 }, | ||
| { | ||
| enum: ['sonar-runtime'], | ||
| }, | ||
| ], |
There was a problem hiding this comment.
I am not sure, but we need to test locally if this anyOf property will still work with the following logic in SonarJS:
There was a problem hiding this comment.
definitely it will not:) good catch. I will see what I can do
There was a problem hiding this comment.
I reverted the change with anyOf. We will have to update configuration of the rule in SonarJS.
I don't see other way :(
src/rules/no-identical-functions.ts
Outdated
| enum: ['sonar-runtime'], | ||
| }, | ||
| ], | ||
| schema: [OPTION_SCHEMA, OPTION_SCHEMA], |
There was a problem hiding this comment.
Did you figure out why we need it twice ?
There was a problem hiding this comment.
yeah, each repetition is a choice between two options so that you can provide them in any order
|
Kudos, SonarCloud Quality Gate passed! |
yassin-kammoun-sonarsource
approved these changes
Feb 15, 2022
yassin-kammoun-sonarsource
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #225