Add suggestion for 'no-same-line-conditional' #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vilchik-elena
requested changes
Mar 24, 2022
| fix: fixer => | ||
| fixer.insertTextBefore( | ||
| followingIf, | ||
| '\n' + ' '.repeat(precedingIf.range[0] - 1), |
There was a problem hiding this comment.
i am not sure it is correct to use range here, I think it should be loc (add test with not first statement)
There was a problem hiding this comment.
How silly of me. It should definitely be based on loc.
…-sonarjs into sonarjs/issue-3020
vilchik-elena
requested changes
Mar 24, 2022
| fix: fixer => | ||
| fixer.insertTextBefore( | ||
| followingIf, | ||
| '\n' + ' '.repeat(precedingIf.loc.start.column), |
|
Kudos, SonarCloud Quality Gate passed! |
vilchik-elena
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SonarSource/SonarJS#3020