Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: feat: add new inputs to clean-up previously added stale comments #912

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

WIP: feat: add new inputs to clean-up previously added stale comments #912

wants to merge 9 commits into from

Conversation

C0ZEN
Copy link
Member

@C0ZEN C0ZEN commented Sep 5, 2022 •
edited

PR Checklist

Please check if your PR fulfils the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated (for bugfix/feature)
  • Docs have been added/updated (for bugfix/feature)
  • Contributing implementation have been added/updated (for bugfix/feature)
  • Website documentation have been added/updated (for bugfix/feature)

PR Type

What kind of change does this PR introduce?

  • Feature (a new feature)
  • Bugfix (a bug fix)
  • Style (changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc))
  • Refactor (a code change that neither fixes a bug nor adds a feature)
  • Perf (a code change that improves performance)
  • Test (adding missing tests or correcting existing tests)
  • Build (changes that affect the build system, CI configuration or external dependencies)
  • Docs (changes that affect the documentation)
  • Chore (anything else), please describe:

What is the current behaviour?

What is the new behaviour?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Closes #175
Closes #174

@C0ZEN C0ZEN added enhancement 🚀 Add a new feature/enhancement merge-into-master 👑 Will create a PR from develop to master labels Sep 5, 2022
@C0ZEN C0ZEN self-assigned this Sep 5, 2022
@C0ZEN C0ZEN added this to In progress in Issues via automation Sep 5, 2022
@C0ZEN C0ZEN added this to In progress in Pull requests via automation Sep 5, 2022
@vercel
Copy link

vercel bot commented Sep 5, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
stale-docs ✅ Ready (Inspect) Visit Preview Sep 6, 2022 at 9:46PM (UTC)

@Sonia-corporation-bot Sonia-corporation-bot added documentation 📚 Improvements or additions to documentation test 🧪 Contains a change in a test file labels Sep 5, 2022
@codecov
Copy link

codecov bot commented Sep 5, 2022 •
edited

Codecov Report

Merging #912 (af52994) into develop (ef485ca) will decrease coverage by 0.11%.
The diff coverage is 90.00%.

❗ Current head af52994 differs from pull request most recent head d99be1a. Consider uploading reports for the commit d99be1a to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #912      +/-   ##
===========================================
- Coverage    99.26%   99.14%   -0.12%     
===========================================
  Files          131      135       +4     
  Lines         3259     3291      +32     
  Branches       344      345       +1     
===========================================
+ Hits          3235     3263      +28     
- Misses          22       26       +4     
  Partials         2        2
Flag Coverage Δ
integration-issues 72.78% <88.23%> (+0.16%) ⬆️
integration-pull-requests 75.81% <88.23%> (+0.13%) ⬆️
unit 99.69% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/inputs/core-inputs.service.ts 100.00% <ø> (ø)
...c/core/processing/issues/issue-ignore-processor.ts 100.00% <ø> (ø)
.../core/processing/issues/issue-include-processor.ts 100.00% <ø> (ø)
...ing/pull-requests/pull-request-ignore-processor.ts 100.00% <ø> (ø)
...ng/pull-requests/pull-request-include-processor.ts 100.00% <ø> (ø)
...ub/api/issues/constants/github-api-issues-query.ts 100.00% <ø> (ø)
...b/api/labels/abstract-github-api-labels.service.ts 100.00% <ø> (ø)
...e-items/github-api-issue-timeline-items.service.ts 100.00% <ø> (ø)
.../github-api-pull-request-timeline-items.service.ts 100.00% <ø> (ø)
src/utils/close/get-parsed-close-reason.ts 100.00% <ø> (ø)
... and 14 more

@C0ZEN
chore(comments): add hidden header in the comments
437f7cc 
They will be used for future features that need to identify the comments that were sent by the action and also which kind of comment they are.
@C0ZEN C0ZEN force-pushed the feature/delete-comments-stale branch from 3f1370d to 437f7cc Compare September 5, 2022 19:47
@codeclimate
Copy link

codeclimate bot commented Sep 5, 2022

Code Climate has analyzed commit af52994 and detected 4 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 4

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 99.7%.

View more on Code Climate.

@C0ZEN C0ZEN changed the title WIP: chore(contributing): add the github schemas checks as part of the ini… WIP: feat: add new inputs to clean-up previously added stale comments Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@C0ZEN C0ZEN

Labels
documentation 📚 Improvements or additions to documentation enhancement 🚀 Add a new feature/enhancement merge-into-master 👑 Will create a PR from develop to master test 🧪 Contains a change in a test file
Projects
Issues
In progress
Pull requests
In progress
Milestone
No milestone
2 participants
@C0ZEN @Sonia-corporation-bot