Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use symlink for buildSrc directories in mc-java and ProtoData instead of checking for same content #450

Open
alexander-yevsyukov opened this issue Jan 14, 2023 · 4 comments
Open

Use symlink for buildSrc directories in mc-java and ProtoData instead of checking for same content #450

alexander-yevsyukov opened this issue Jan 14, 2023 · 4 comments

Comments

@alexander-yevsyukov
Copy link
Contributor

The scripts/generate-documentation/buildSrc directory is actually a symlink, which is convenient because reduces the efforts for manual synchronization.

Let's apply this approach to mc-java and ProtoData that have to have buildSrc directories under integration tests.
@alexander-yevsyukov
Copy link
Contributor Author

@armiol, FYI.

@armiol
Copy link
Contributor

armiol commented Jan 14, 2023

@alexander-yevsyukov
I would test this with Windows. Because last time I used Windows, they did not have symlinks.

@alexander-yevsyukov
Copy link
Contributor Author

I would test this with Windows. Because last time I used Windows, they did not have symlinks.

They seem to have now.

@alexander-yevsyukov
Copy link
Contributor Author

We can also speed up our integration tests by creating symlinks in a directories of test projects instead of copying buildSrc into them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@armiol @alexander-yevsyukov