Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two bugs causing failure on accessibility #101

Open
2 tasks done
ohassanx opened this issue Nov 15, 2023 · 0 comments
Open
2 tasks done

Two bugs causing failure on accessibility #101

ohassanx opened this issue Nov 15, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@ohassanx
Copy link

Checks

Version

0.6.12

Description

These are the two errors that is being shown when running lighthouse on a page that currently uses vue-splide.
Screenshot 2023-11-15 at 08 51 02
This specific error comes from having the li elements have the role="group" whereas the parent ul element has the role="presentation" which is not compatible as it does not pass the aria-role validation. https://dequeuniversity.com/rules/axe/4.8/aria-roles
Screenshot 2023-11-15 at 08 51 11
This specific error comes from having aria-hidden="true" on slides that are currently not in view.

Reproduction Link

No response

Steps to Reproduce

  1. Run lighthouse on a page that uses vue-splide.

Expected Behaviour

To not have these two errors in lighthouse.
To remove aria-hidden="true" from slides that are not in view.
To have the correct role for the ul element and not presentation so the correct role in this case would be role="Widget".

@ohassanx ohassanx added the bug Something isn't working label Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant