Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

During update and uninstall some unrelated shortcuts pinned to the taskbar may get updated #1238

Open
xbb opened this issue Jan 23, 2018 · 2 comments · May be fixed by #1490
Open

During update and uninstall some unrelated shortcuts pinned to the taskbar may get updated #1238

xbb opened this issue Jan 23, 2018 · 2 comments · May be fixed by #1490
Labels
bug:failing-test-would-be-nice Issues that would benefit from an automated test to confirm the problem help wanted Issues and features that are open to external contribution

Comments

@xbb
Copy link

xbb commented Jan 23, 2018

Two, or more applications with names that begin the same for example:

MyApp and MyAppTwo

If I have both the apps pinned on the taskbar and I update or uninstall MyApp the shortcuts of the other app MyAppTwo pinned to the taskbar will be updated too.

Could this be the issue?

Squirrel.Windows/src/Squirrel/UpdateManager.ApplyReleases.cs

Line 454 in b25c9fa

if (!shortcut.Target.StartsWith(rootAppDirectory, StringComparison.OrdinalIgnoreCase)) continue;

@shiftkey
Copy link
Contributor

shiftkey commented May 5, 2019

Could this be the issue?

This does seem plausible.

@shiftkey shiftkey added bug:old-version Issues that target a very old version of the library, and should be retested if possible bug:failing-test-would-be-nice Issues that would benefit from an automated test to confirm the problem help wanted Issues and features that are open to external contribution and removed bug:old-version Issues that target a very old version of the library, and should be retested if possible labels May 5, 2019
@gojanpaolo
Copy link
Contributor

changing the said line to if (!Path.GetDirectoryName(shortcut.Target).Equals(rootAppDirectory, StringComparison.OrdinalIgnoreCase)) continue; fixes the issue. Now, I just need to figure out how to create unit test for it :)

@gojanpaolo gojanpaolo linked a pull request May 16, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug:failing-test-would-be-nice Issues that would benefit from an automated test to confirm the problem help wanted Issues and features that are open to external contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix taskbar shorcut update gojanpaolo/Squirrel.Windows
3 participants
@xbb @shiftkey @gojanpaolo