-
-
Notifications
You must be signed in to change notification settings - Fork 739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Concurrency policy not running if set to one #6044
Comments
If this seems like an actual bug to anyone else, I can make the PR for it. |
Following this logic, when you set the concurrency to @FileMagic if you're sure there's a bug, - definitely submit a PR 👍 I didn't have a chance to use concurrency for a long time. |
For us, the workflows work when I set concurrency to 1. |
Orquesta This suggests that Orquesta with-items and Action concurrency are cumulative. Orquesta could have a concurrency of 3 items and the action being called have an action concurrency of 1, in which case, 3 actions would be scheduled at a time with only 1 actually running in parallel. I did a bit of testing and found that when Orquesta has concurrency set to 0 the workflow remains block. StackStorm/orquesta#259 |
to be clear this is in reference to policy not concurrency settings. |
SUMMARY
If you were to set the concurrency policy of an action to be 1 then it does not run any actions. I believe the following piece of code is responsible:
https://github.com/StackStorm/st2/blob/d374b92f0dbf6b26c5dfdcffd594ecbd0800d635/st2actions/st2actions/policies/concurrency.py#L53C12-L53C34
I think this should be changed to:
and a unit test should be added.
Steps to reproduce the problem
Set the policy to be 1 for a specific action in stackstorm, and try to run the action using something like with items.
Expected Results
One action running at a time.
Actual Results
No actions run and they stay in the policy_action state.
The text was updated successfully, but these errors were encountered: