Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have non-live articles show a banner when displayed #611

Closed
LeMurphant opened this issue May 2, 2024 · 8 comments
Closed

Have non-live articles show a banner when displayed #611

LeMurphant opened this issue May 2, 2024 · 8 comments
Labels
enhancement New feature or request

Comments

@LeMurphant
Copy link

ref https://discord.com/channels/677546901339504640/1219361047077453845/1235590654512467968

In theory, these articles should not be easily accessible, but if we make a mistake or someone goes to the URL directly, they can reach them, e.g. https://discord.com/channels/677546901339504640/1219361047077453845/1235590654512467968

While I was not able to find the old banner, but I'm quite confident that it used to tell you you were in progress on the old site

IIRC the determining factor to see if it shows on site is Coda, not the Gdocs location

@LeMurphant LeMurphant added the enhancement New feature or request label May 2, 2024
@mruwnik
Copy link
Collaborator

mruwnik commented May 22, 2024

it used to look like this:

Image

@melissasamworth
Copy link
Contributor

@LeMurphant I'm a bit confused about this task. The links go to an empty Discord for me. Can you give me links to these types of articles so I can check Nemo's implementation? Each of the 3 I guess (Still uncertain about the design choices here but nbd).

@LeMurphant
Copy link
Author

I think we never ended up using "Controversial" and "Well established", although we might in the future. I think implementing them is low priority.
@melissasamworth An example of an article that would fit "In progress" is this one
https://aisafety.info/questions/8W8C/
Note it should in theory not be discoverable, but it could be if we make a mistake (which is likely to happen sometimes).

@mruwnik
Copy link
Collaborator

mruwnik commented May 26, 2024

it's not on master, so check this link: https://redesign.aprillion.workers.dev/questions/8W8C/
Or go to the example question: https://redesign.aprillion.workers.dev/questions/0

@mruwnik
Copy link
Collaborator

mruwnik commented May 26, 2024

@melissasamworth you can change the colours and icon here - they get fetched from coda

@melissasamworth
Copy link
Contributor

@mruwnik what's this weird shadow thing?

Like 24px below the callout

Image

@mruwnik
Copy link
Collaborator

mruwnik commented May 28, 2024

Where?
image

@LeMurphant
Copy link
Author

I like it! I'll close the issue since the feature is now present, but @melissasamworth feel free to open a new one for the shadow issue if you think it's relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

3 participants