Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json #76

Closed
warpech opened this issue Apr 26, 2018 · 20 comments
Closed

Update package.json #76

warpech opened this issue Apr 26, 2018 · 20 comments
Assignees

Comments

@warpech
Copy link
Contributor

warpech commented Apr 26, 2018

For reasons enclosed on Slack: https://starcounter.slack.com/archives/C7677F70W/p1524776857000399

@warpech
Copy link
Contributor Author

warpech commented Apr 27, 2018

@alshakero
Copy link
Contributor

alshakero commented Apr 27, 2018

It will appear wherever Polymer 2.0 appears.

@alshakero
Copy link
Contributor

alshakero commented May 7, 2018

Closing as it's a false flag, see request/request#2926 (comment)

Extra assurance from a GH staffer: hapijs/hoek#247 (comment)

@alshakero alshakero reopened this May 21, 2018
@alshakero
Copy link
Contributor

Reopening as 2.16.3 is indeed infected. The false flag was for 4.2.1.

@warpech
Copy link
Contributor Author

warpech commented May 28, 2018

This is not urgent, moving to July.

@warpech
Copy link
Contributor Author

warpech commented Jun 22, 2018

Web Components Tester 6.7.0 was released this week. I suppose it might fix the vulnerabilities alerts: https://github.com/Polymer/tools/releases/tag/web-component-tester%406.7.0

Edit: it might not be enough, given this PR that was started afterwards: Polymer/tools#533

@alshakero
Copy link
Contributor

Polymer/tools#533 is still WIP

@warpech
Copy link
Contributor Author

warpech commented Jul 3, 2018

Meanwhile, I can see that some of our vulnerabilities actually don't depend on it:

@alshakero
Copy link
Contributor

the vulnerability in Palindrom/Palindrom seems to be in our control by upgrading Mocha to the current version

PR in Palindrom/Palindrom#213

@warpech
Copy link
Contributor Author

warpech commented Jul 30, 2018

There is a general solution that should be applied in all affected repos that have web-component-tester in package.json: Starcounter/starcounter-include#106

@alshakero could you pls apply it in all relevant repos?

@warpech
Copy link
Contributor Author

warpech commented Aug 2, 2018

What's the status of this?

@alshakero
Copy link
Contributor

It is blocked by this Palindrom/Palindrom#213

@warpech
Copy link
Contributor Author

warpech commented Aug 2, 2018

Meanwhile, can you look at other custom element repos, such as https://github.com/Starcounter/starcounter-layout-html-editor?

@alshakero
Copy link
Contributor

@alshakero
Copy link
Contributor

Closing as finally done. I think all security warnings are fixed at this point except Blending's one which should be fixed here https://github.com/Starcounter/Blending/pull/277.

Are you aware of any other security warnings?

@warpech
Copy link
Contributor Author

warpech commented Aug 13, 2018

Do you have "Vulnerability alerts" subscribed on the page https://github.com/settings/notifications?

Every day I get a daily digest with the repos that still have vulnerabilities. Today's report includes:

@warpech warpech reopened this Aug 13, 2018
@alshakero
Copy link
Contributor

alshakero commented Aug 13, 2018

Do you have "Vulnerability alerts" subscribed on the page github.com/settings/notifications?

Now I do.

Blending should be fixed by this PR https://github.com/Starcounter/Blending/pull/277

@Mihaiii Mihaiii self-assigned this Aug 13, 2018
@alshakero
Copy link
Contributor

alshakero commented Aug 13, 2018

  1. Palindrom/puppetjs.github.io, I archived the repo.
  2. Palindrom/palindrom.github.io, Fixed
  3. Juicy/juicy.github.io, working on it. Fixed.
  4. Starcounter/SignIn, tracked here Fixed.
  5. Starcounter/People, PR here. Fixed.
  6. Starcounter/Blending PR here. Fixed.

@alshakero
Copy link
Contributor

Closing as all fixed.

@warpech
Copy link
Contributor Author

warpech commented Aug 15, 2018

Huge victory! Thanks everyone involved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants