Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Write tests for the s3-pull extension #2249

Open
crayolakat opened this issue Dec 16, 2022 · 1 comment
Open

Feature Request: Write tests for the s3-pull extension #2249

crayolakat opened this issue Dec 16, 2022 · 1 comment
Labels
A-testing Area: a test, testing coverage, meta discussions about testing C-enhancement Type: enhancement

Comments

@crayolakat
Copy link
Collaborator

Problem
The s3-pull contact loader extension currently doesn't have any tests.

Solution
Create a Jest test for the s3-pull contact loader extension.

Context
The AWS.S3 function will need to be mocked: https://github.com/MoveOnOrg/Spoke/blob/2e8c479ef7e4071bc903bdf882334488b50f2910/src/extensions/contact-loaders/s3-pull/index.js#L92

This may entail needing to refactor some code, although there's probably another way to do it
@crayolakat crayolakat added C-enhancement Type: enhancement A-testing Area: a test, testing coverage, meta discussions about testing labels Dec 16, 2022
@crayolakat crayolakat mentioned this issue Dec 16, 2022
Open
7 tasks
@crayolakat
Copy link
Collaborator Author

@lastminutediorama suggested to consider adding localstack to our docker-compose dev containers for this because it's pretty handy for local s3 testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testing Area: a test, testing coverage, meta discussions about testing C-enhancement Type: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@crayolakat