Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Avoid login in source site when using exported file #148

Open
ngosang opened this issue Mar 26, 2021 · 1 comment
Open

Comments

@ngosang
Copy link
Contributor

ngosang commented Mar 26, 2021

If all required information is in the exported file. Why we have to perform login in the source site?
In best case it takes time, in worst case there is an error and you can't import.

$ python3 transfer_ratings.py --s trakt -f /home/kizar/repositories/RatS/RatS/exports/20210326181821_Trakt_mod.json -d letterboxd
===== Trakt: performing login
===== loaded 2 movies from /home/xxx/repositories/RatS/RatS/exports/20210326181821_Trakt_mod.json
===== Letterboxd:  ...
@StegSchreck StegSchreck added this to Backlog in RatS via automation Mar 29, 2021
@StegSchreck StegSchreck added this to the v1.0 milestone Mar 29, 2021
@StegSchreck
Copy link
Owner

Right, this was a workaround at the beginning to initialize the source Site object. I agree that it would be cleaner to separate the initialization from the login. Thanks for your input!

@StegSchreck StegSchreck removed this from the v1.0 milestone Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
RatS
  
Backlog
Development

No branches or pull requests

2 participants