-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HoloLens 2 Mixed Reality Capture's viewfinder not showing #982
Comments
At times, we've also noticed that when MRC is activated in an SK app, it will crash unexpectedly. Closing the app or restarting usually resolves it. Unfortunately, I don't have any additional logs or debugging info yet |
I'm about to wrap up some work on a tricky feature, but after that I think I owe UWP (like #981) a bit of time and attention. I'll definitely be looking into this next week! |
Sweeet, thanks so much :) |
Likewise, thanks! |
On the version/0.3.10 branch using the following repro strategy:
I am still getting the error, but there's some hope! By commenting out the primary display's OpenXR composition layer when the secondary display is active, it successfully shows the viewfinder again but obviously nothing in StereoKit is rendered :D so I'm a little stuck here at the moment Another quirk is if you're debugging it and set a breakpoint with the branch's code, it'll actually show up as it should so maybe SK is holding onto something with the primary display? |
Is this specifically about the viewfinder corners? Not a crash of any sort? I was able to see the corners not showing up the first time after restart, but I haven't seen any functional impact beyond that. The recording camera icon was still visible there too!
I wonder if this is maybe a composition layer order issue? Maybe HL2's viewfinder composition layer sorts itself underneath SK's projection layer in some cases. If that is what's happening, then this might be very tricky to solve on our end. We don't really have control over ordering of composition layers outside of our own. |
This is mainly about the viewfinder corners! I haven't been able to repro a crash anymore. The performance in the StereoKit test app definitely looks normal (stable 30 FPS with MRC enabled). I tried the BasicXrApp in https://github.com/microsoft/OpenXR-MixedReality and it had the same issue, so maybe I'll drop it there. Perhaps it's an OpenXR-related bug since non OpenXR apps don't have this issue |
Okay, if that project also reproduces it, I'm not feeling so bad about this 😅 I guess this is not currently a blocker or anything at this point? I did find/fix a couple sketchy code-paths with the secondary view when re-writing the swapchain code to support MSAA! I'm not so sure they'd have been common problems (or problems at all), but the new code does bullet-proof that feature a fair bit more than before. If you catch any hints of problems still coming from there with v0.3.10 though, lemme know! |
Nope, not a blocker! Thanks for fixing up those paths, it's much appreciated :) They'll get some traffic as I update to the new version I'll close this one and make an issue over there because I repro'd in their OpenXR Tools official sample too with the latest runtime |
Description
To reproduce, restart the device. Open a StereoKit app, and say "Start Recording". Starting in October 2023, a viewfinder for the HoloLens 2 should appear when recording. It isn't until you exit the SK app that you'll be able to see the viewfinder when starting another recording or MRC session.
A strange tidbit is that if you start a recording outside of the SK app, the viewfinder appears as expected. But, if you jump back into the SK app and try to reproduce with a new recording, the viewfinder will appear. That's why I recommend restarting the device in order to reproduce.
Platform / Environment
HoloLens 2 UWP. Tested in v0.3.6 -> v0.3.9
Logs or exception details
I was able to get the
std::runtime_error
once after a fresh device restart, but it does not always occur. The rest of the log is consistent for successive runs of the app. The holographic space/camera exceptions appear when you stop recording, both when the frustum is and is not visible.The text was updated successfully, but these errors were encountered: