Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding newline(s) after header #29

Merged
merged 2 commits into from Aug 31, 2020
Merged

Adding newline(s) after header #29

merged 2 commits into from Aug 31, 2020

Conversation

emoller
Copy link
Contributor

@emoller emoller commented Aug 22, 2020 •
edited by Stuk

  • Updates the project to use the latest version of eslint and mocha.
  • Adds support for a 3rd argument specifying number of newlines to add after the header.
  • Review it without whitespace since a big chunk of the code got indented one level.

Fixes #28

@emoller
Copy link
Contributor Author

emoller commented Aug 23, 2020

The travis check is failing when linting the node_modules folder which I though was always excluded. Do we need to bump the travis config to build with a newer node? I'm testing this on node 14.8.0 and the travis config is building with node 8 by the looks. Never used travis before so don't know if there are any other quirks I'm missing.

opera-duanei
opera-duanei approved these changes Aug 24, 2020
View reviewed changes
Copy link

@opera-duanei opera-duanei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

lib/rules/header.js Show resolved Hide resolved
lib/rules/header.js Outdated Show resolved Hide resolved
lib/rules/header.js Outdated Show resolved Hide resolved
lib/rules/header.js Outdated Show resolved Hide resolved
Stuk
Stuk approved these changes Aug 31, 2020
View reviewed changes
Copy link
Owner

@Stuk Stuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks!

@Stuk Stuk changed the title Adding newline(s) after header #28 Adding newline(s) after header Aug 31, 2020
@Stuk Stuk merged commit 8b26250 into Stuk:master Aug 31, 2020
@Stuk
Copy link
Owner

Stuk commented Aug 31, 2020

Published as 3.1.0

@DLehenbauer
Copy link

@emoller, @Stuk - Works great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stuk Stuk Stuk approved these changes

@opera-duanei opera-duanei opera-duanei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request - Adding newline(s) after header
4 participants
@emoller @Stuk @DLehenbauer @opera-duanei