Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid field labels not styled and input icons not visible #597

Closed
xt0rted opened this issue Mar 23, 2018 · 5 comments
Closed

Invalid field labels not styled and input icons not visible #597

xt0rted opened this issue Mar 23, 2018 · 5 comments

Comments

@xt0rted
Copy link
Member

xt0rted commented Mar 23, 2018

  • Browser: Chrome 65
  • Operating System: Win10
  • Screenshot:

https://github.com/settings/admin

image

image

  • HTML of the section where the issue occurs:
<input type="password" name="user[password]" id="user_new_password" data-autocheck-url="/signup_check/password" data-autocheck-authenticity-token="" tabindex="2" required="required" class="form-control is-autocheck-errored" data-com.agilebits.onepassword.user-edited="yes">
@Mottie
Copy link
Member

Mottie commented Mar 23, 2018

Hi @xt0rted!

It looks like the invalid css selector (:not(li.moved)) mentioned in #589 is causing the block that styles the error label color to be ignored. I think we might need to either separate those invalid rules into a separate block, or ignore them for now. What do you think @silverwind?

I'll work on a fix for the icon.

@Mottie
Copy link
Member

Mottie commented Mar 23, 2018

I opened csstree/validator#10.

Now, I need to figure out how to include csstree as a stylelint plugin in Stylus...

@Mottie Mottie closed this as completed in d5be14e Mar 24, 2018
@Mottie
Copy link
Member

Mottie commented Mar 24, 2018

I ended up removing the troublesome selector in the generate process.

@silverwind
Copy link
Member

Nice work. So the issue was the the invalid selector invalidated the combined minfied rule?

@Mottie
Copy link
Member

Mottie commented Mar 27, 2018

So the issue was the the invalid selector invalidated the combined minfied rule

Yep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants