lsp: Poll workspace state to detect state changes #954
+95
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charlie Egan <charlie@styra.com>
This reverts commit f0bce94. I am going to use a simple polling approach.
Fixes StyraInc#857 I will add some notes to the issue too, but in short I found that it wasn't possible to catch new files added to new directories without some polling-based delay. So I have opted for the keep it simple approach for now. Signed-off-by: Charlie Egan <charlie@styra.com>
anderseknert
approved these changes
Aug 1, 2024
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
* WIP: attempt to use fsnotify reliably Signed-off-by: Charlie Egan <charlie@styra.com> * Revert "WIP: attempt to use fsnotify reliably" This reverts commit f0bce94. I am going to use a simple polling approach. * lsp: Poll workspace state to detect state changes Fixes StyraInc#857 I will add some notes to the issue too, but in short I found that it wasn't possible to catch new files added to new directories without some polling-based delay. So I have opted for the keep it simple approach for now. Signed-off-by: Charlie Egan <charlie@styra.com> --------- Signed-off-by: Charlie Egan <charlie@styra.com>
charlieegan3
added a commit
to charlieegan3/regal
that referenced
this pull request
Jan 6, 2025
* WIP: attempt to use fsnotify reliably Signed-off-by: Charlie Egan <charlie@styra.com> * Revert "WIP: attempt to use fsnotify reliably" This reverts commit f0bce94. I am going to use a simple polling approach. * lsp: Poll workspace state to detect state changes Fixes StyraInc#857 I will add some notes to the issue too, but in short I found that it wasn't possible to catch new files added to new directories without some polling-based delay. So I have opted for the keep it simple approach for now. Signed-off-by: Charlie Egan <charlie@styra.com> --------- Signed-off-by: Charlie Egan <charlie@styra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #857
I will add some notes to the issue too, but in short I found that it
wasn't possible to catch new files added to new directories without some
polling-based delay. So I have opted for the keep it simple approach for
now.
f0bce94
was an attempt to get the fsnotify based implementation working before I opted
to just poll instead.
Note, this will ignore files that are present in the cache but with a different content in case the file is in an open buffer, we will continue to use that contents.