Allow using regal fix as a formatter
#960
Merged
+115
−88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anderseknert
force-pushed
the
regal-fix-format
branch
from
94004d1 to
6ba240a
Compare
charlieegan3
approved these changes
Aug 5, 2024
Also: - Removed the code that would send a response back for formatter options that `opa fmt` can't handle. This was a good idea, but since there isn't any obvious way for users to fix that, it hurts more than it helps - Removed the fmt fix from the default fixer options as formatting is done anyway by the rego-v1 fixer Fixes #839 Signed-off-by: Anders Eknert <anders@styra.com>
anderseknert
force-pushed
the
regal-fix-format
branch
from
6ba240a to
9082db2
Compare
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
Also: - Removed the code that would send a response back for formatter options that `opa fmt` can't handle. This was a good idea, but since there isn't any obvious way for users to fix that, it hurts more than it helps - Removed the fmt fix from the default fixer options as formatting is done anyway by the rego-v1 fixer Fixes StyraInc#839 Signed-off-by: Anders Eknert <anders@styra.com>
charlieegan3
pushed a commit
to charlieegan3/regal
that referenced
this pull request
Jan 6, 2025
Also: - Removed the code that would send a response back for formatter options that `opa fmt` can't handle. This was a good idea, but since there isn't any obvious way for users to fix that, it hurts more than it helps - Removed the fmt fix from the default fixer options as formatting is done anyway by the rego-v1 fixer Fixes StyraInc#839 Signed-off-by: Anders Eknert <anders@styra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
opa fmtcan't handle. This was a good idea, but since there isn't any obvious way for users to fix that, it hurts more than it helpsFixes #839