Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax highlighting broken since build 3093 #167

Open
sampotts opened this issue Jul 31, 2015 · 5 comments
Open

Syntax highlighting broken since build 3093 #167

sampotts opened this issue Jul 31, 2015 · 5 comments

Comments

@sampotts
Copy link

As title basically, upgraded to 3093 because the popup just wouldn't go away (needs a skip this version) and then it broke code highlighting in JS. I've tried 3094 and 3095, same deal. Looks like 3093 caused it.

screen shot 2015-07-31 at 3 31 10 pm

Suggest sticking to 3092 if anyone was thinking of upgrading...

@sampotts
Copy link
Author

Here's 3092...

screen shot 2015-07-31 at 3 35 01 pm

@philipbordallo
Copy link

@sampotts Yeah, it weirded me out as well. But from the looks of it, pre-3093 highlighting was actually incorrect and variables are supposed to be red.

Might be a good idea to file an issue with base16-builder.

Here is a quick bandaid to get things back the way they were. Add this to base16-ocean.dark.tmTheme:

<dict>
    <key>name</key>
    <string>JS Variables</string>
    <key>scope</key>
    <string>source.js variable.other, variable.function.js</string>
    <key>settings</key>
    <dict>
        <key>foreground</key>
        <string>#c0c5ce</string>
    </dict>
</dict>
<dict>
    <key>name</key>
    <string>JS DOM Support</string>
    <key>scope</key>
    <string>support.type.object.dom</string>
    <key>settings</key>
    <dict>
        <key>foreground</key>
        <string>#ebcb8b</string>
    </dict>
</dict>
<dict>
    <key>name</key>
    <string>JS Properties</string>
    <key>scope</key>
    <string>constant.other.object.key.js, string.unquoted.label.js</string>
    <key>settings</key>
    <dict>
        <key>foreground</key>
        <string>#c0c5ce</string>
    </dict>
</dict>

@sampotts
Copy link
Author

Awesome. Only thing is, where do I find that file? I looked in Application Support, no dice?

Edit. Found it. Had to change the .sublime-package to .zip and then edit the file and reverse that process. 👍

@philipbordallo
Copy link

@sampotts It's where your packages are installed and most likely in a folder named spacegray. On a Mac this will be ~/Library/Application Support/Sublime Text 3/Packages.

@dlsso
Copy link

dlsso commented Jan 11, 2017

I got this message from sublime text today:

Fixes in Spacegray 1.3.2:

  • Fixed red-heavy syntax in JS
  • Fixed text input field alignment
  • Fixed image link color highlighting in Markdown
  • Fixed Oceanic Theme input field backgorund color

However, I still have red everywhere. Is the "band aid" the only thing I can do right now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants