Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename the execute function #64

Open
Fabien-GELUS opened this issue Oct 7, 2022 · 1 comment · May be fixed by #66
Open

rename the execute function #64

Fabien-GELUS opened this issue Oct 7, 2022 · 1 comment · May be fixed by #66

Comments

@Fabien-GELUS
Copy link
Contributor

Fabien-GELUS commented Oct 7, 2022

In function.py we have 2 different execute functions, and it's really difficult when calling for instance function.execute([to know which one is used, we have to track the function object type.
I propose to rename one of them, like execute_function for the one in wrapper or execute_cli for the one running the cli

@ThibaultFy
Copy link
Member

I agree that it is confusing. I propose to keep execute for the cli as it is the function exposed to the user, in order to keep a name as simple as possible, and to rename to execute_function for the wrapper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants