Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove experimental decorators check from SWC config #40

Open
scssyworks opened this issue Jul 18, 2023 · 2 comments
Open

Remove experimental decorators check from SWC config #40

scssyworks opened this issue Jul 18, 2023 · 2 comments

Comments

@scssyworks
Copy link

In current code we are enabling decorators using experimentalDecorators check from tsconfig. This is no longer needed since TypeScript 5 supports decorators stage 3 proposal without a flag. Additionally experimentalDecorators flag enables the legacy decorators and SWC now supports decorators stage 3 proposal as of version 1.3.47 (See: https://swc.rs/docs/configuration/compilation#jsctransformdecoratorversion).

I will be raising a pull request for proposed changes. Let me know your thoughts.
@SukkaW
Copy link
Owner

SukkaW commented Jul 19, 2023

That makes sense. Looking forward to your PR!

@SukkaW
Copy link
Owner

SukkaW commented Jul 28, 2023 •
edited

@scssyworks Hello, are you still planning to create the PR for your proposal?

Also, should we detect whether a user is using TypeScript 5, to avoid the breaking change?

@nonzzz nonzzz mentioned this issue Nov 24, 2023
Draft
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@scssyworks @SukkaW